Skip to main content

Lint clippy::implicit_clone

warning clippy::implicit_clone §

implicitly cloning a `OsString` by calling `to_os_string` on its dereferenced type

src/cli.rs:80:17

Clippy · Category: pedantic · cargo-clippy-html

Official Clippy documentation

Targets (1)
  • cargo-clippy-html (bin)

Primary: src/cli.rs:80:17

                args.get(i)
                    .ok_or_else(|| format!("{name} requires a value"))?
                    .to_os_string()

help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.100.0/index.html#implicit_clone

note: `-W clippy::implicit-clone` implied by `-W clippy::pedantic`

help: to override `-W clippy::pedantic` add `#[allow(clippy::implicit_clone)]`

help: consider using

Suggestion: consider using

MachineApplicable

--- "a/src/cli.rs"
+++ "b/src/cli.rs"
@@ -77,9 +77,8 @@
                 OsString::from(v)
             } else {
                 i += 1;
-                args.get(i)
-                    .ok_or_else(|| format!("{name} requires a value"))?
-                    .to_os_string()
+                (*args.get(i)
+                    .ok_or_else(|| format!("{name} requires a value"))?).clone()
             };
             if name == "--target-dir" {
                 context.target_dir_override = Some(cwd.join(value));
Rendered diagnostic (text)
warning: implicitly cloning a `OsString` by calling `to_os_string` on its dereferenced type
  --> src/cli.rs:80:17
   |
80 | /                 args.get(i)
81 | |                     .ok_or_else(|| format!("{name} requires a value"))?
82 | |                     .to_os_string()
   | |___________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.100.0/index.html#implicit_clone
   = note: `-W clippy::implicit-clone` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::implicit_clone)]`
help: consider using
   |
80 ~                 (*args.get(i)
81 +                     .ok_or_else(|| format!("{name} requires a value"))?).clone()
   |

warning clippy::implicit_clone §

implicitly cloning a `OsString` by calling `to_os_string` on its dereferenced type

src/cli.rs:93:40

Clippy · Category: pedantic · cargo-clippy-html

Official Clippy documentation

Targets (1)
  • cargo-clippy-html (bin)

Primary: src/cli.rs:93:40

            context.metadata_args.push(args[i].to_os_string());

help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.100.0/index.html#implicit_clone

help: consider using

Suggestion: consider using

MachineApplicable

--- "a/src/cli.rs"
+++ "b/src/cli.rs"
@@ -90,7 +90,7 @@
             name,
             "--locked" | "--offline" | "--frozen" | "--all-features" | "--no-default-features"
         ) {
-            context.metadata_args.push(args[i].to_os_string());
+            context.metadata_args.push(args[i].clone());
         }
         i += 1;
     }
Rendered diagnostic (text)
warning: implicitly cloning a `OsString` by calling `to_os_string` on its dereferenced type
  --> src/cli.rs:93:40
   |
93 |             context.metadata_args.push(args[i].to_os_string());
   |                                        ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `args[i].clone()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.100.0/index.html#implicit_clone