Skip to main content

Lint clippy::single_char_pattern

warning clippy::single_char_pattern §

single-character string constant used as pattern

src/metadata.rs:290:27

Clippy · Category: pedantic · cargo-clippy-html

Official Clippy documentation

Targets (1)
  • cargo-clippy-html (bin)

Primary: src/metadata.rs:290:27

                .contains("%")

help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.100.0/index.html#single_char_pattern

note: `-W clippy::single-char-pattern` implied by `-W clippy::pedantic`

help: to override `-W clippy::pedantic` add `#[allow(clippy::single_char_pattern)]`

help: consider using a `char`

Suggestion: consider using a `char`

MachineApplicable

--- "a/src/metadata.rs"
+++ "b/src/metadata.rs"
@@ -287,7 +287,7 @@
                 .as_ref()
                 .unwrap()
                 .url
-                .contains("%")
+                .contains('%')
         );
         for text in [None, Some("changed".into())] {
             sources.values_mut().next().unwrap().text = text;
Rendered diagnostic (text)
warning: single-character string constant used as pattern
   --> src/metadata.rs:290:27
    |
290 |                 .contains("%")
    |                           ^^^ help: consider using a `char`: `'%'`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.100.0/index.html#single_char_pattern
    = note: `-W clippy::single-char-pattern` implied by `-W clippy::pedantic`
    = help: to override `-W clippy::pedantic` add `#[allow(clippy::single_char_pattern)]`

warning clippy::single_char_pattern §

single-character string constant used as pattern

tests/integration.rs:547:56

Clippy · Category: pedantic · cargo-clippy-html

Official Clippy documentation

Targets (1)
  • integration (test)

Primary: tests/integration.rs:547:56

    assert!(active.text().collect::<String>().contains("1"));

help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.100.0/index.html#single_char_pattern

note: `-W clippy::single-char-pattern` implied by `-W clippy::pedantic`

help: to override `-W clippy::pedantic` add `#[allow(clippy::single_char_pattern)]`

help: consider using a `char`

Suggestion: consider using a `char`

MachineApplicable

--- "a/tests/integration.rs"
+++ "b/tests/integration.rs"
@@ -544,7 +544,7 @@
         .next()
         .expect("active source file");
     assert!(active.text().collect::<String>().contains("lib.rs"));
-    assert!(active.text().collect::<String>().contains("1"));
+    assert!(active.text().collect::<String>().contains('1'));
     let finding = doc
         .select(&Selector::parse(".source-findings a").unwrap())
         .next()
Rendered diagnostic (text)
warning: single-character string constant used as pattern
   --> tests/integration.rs:547:56
    |
547 |     assert!(active.text().collect::<String>().contains("1"));
    |                                                        ^^^ help: consider using a `char`: `'1'`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.100.0/index.html#single_char_pattern
    = note: `-W clippy::single-char-pattern` implied by `-W clippy::pedantic`
    = help: to override `-W clippy::pedantic` add `#[allow(clippy::single_char_pattern)]`